Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editSelection option to config #6285

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 2, 2022

So that modifying selections after creation could be disabled.
@nicolaskruchten
@plotly/plotly_js

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM, pending @nicolaskruchten verifying that this fixes the issue with FigureWidget

@nicolaskruchten
Copy link
Contributor

Yes, I'm able to hack the widget a bit to make this work. However, when I set this option to true, the shift-selection behaviour is pretty weird: if I make an initial selection it's fine, then shift-click-drag to make a new one doesn't give me the incremental box as I drag, and when I mouse-up, the box is pinned to my mouse and doesn't 'take' until I click.

@archmoj
Copy link
Contributor Author

archmoj commented Aug 9, 2022

Yes, I'm able to hack the widget a bit to make this work. However, when I set this option to true, the shift-selection behaviour is pretty weird: if I make an initial selection it's fine, then shift-click-drag to make a new one doesn't give me the incremental box as I drag, and when I mouse-up, the box is pinned to my mouse and doesn't 'take' until I click.

@alexcjohnson I think we are happy with this current GUI default. No?

@nicolaskruchten
Copy link
Contributor

This clearly feels like a bug to me... when the circle appears around my cursor is when my mouse button is down.

Screen.Recording.2022-08-09.at.10.06.23.mov

@archmoj
Copy link
Contributor Author

archmoj commented Aug 9, 2022

This clearly feels like a bug to me... when the circle appears around my cursor is when my mouse button is down.

Screen.Recording.2022-08-09.at.10.06.23.mov

That doesn't happen at plotly.js level. Right?
Also this PR is related to providing the false option. I mean the true option behaves the same before and after this PR.

@nicolaskruchten
Copy link
Contributor

This does happen at the Plotly.js level... And this behaviour only appears in false mode, so it's a bug with this PR basically, right?

@nicolaskruchten
Copy link
Contributor

This does happen at the Plotly.js level

Sorry, if you meant "does this happen outside of Jupyter in a CodePen?" the answer appears to be no.

@nicolaskruchten
Copy link
Contributor

And this behaviour only appears in false mode

Well, apparently this isn't true either 🤯 ... Even without this flag set, I get this odd behaviour in Jupyter. OK then, please ignore the noise, we can merge this PR.

@archmoj archmoj merged commit a154ab9 into master Aug 9, 2022
@archmoj archmoj deleted the config-editSelection-option branch August 9, 2022 15:06
kMutagene added a commit to plotly/Plotly.NET that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants